Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.6 Faulty and oversized Entry Merge Editor Pop Up Window when merging bib data from web. #8752

Open
2 tasks done
anton-vrba opened this issue May 3, 2022 · 10 comments
Open
2 tasks done
Labels

Comments

@anton-vrba
Copy link

JabRef version

5.6 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Enter an ISBN
  2. Click: Get Bib Data from web,
  3. Pop up window for merge is buggy, does not show correctly.

Appendix


@ThiloteE
Copy link
Member

ThiloteE commented May 3, 2022

Could you provide a screenshot or explain more in detail of what you mean with "merge is buggy" and "does not show correctly"?

@ThiloteE ThiloteE added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label May 3, 2022
@anton-vrba
Copy link
Author

JabRef 5.7--2022-05-02--4718930
Windows 10 10.0 amd64
Java 17.0.3
JavaFX 18+12

I enclose the screendump, the popup is oversized and only shows part of the data to be merged. But once one tries to resize by dragging edges then the rest of the information becomes visible.

screendump

@ThiloteE ThiloteE added ui and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels May 3, 2022
@ThiloteE
Copy link
Member

ThiloteE commented May 3, 2022

There will be a major overhaul of the entry merge editor. See #6190
Maybe it can be solved during this rework.

@ThiloteE ThiloteE changed the title 5.6 Faulty Pop Up Window when merging bib data from web. 5.6 Faulty and oversized Entry Merge Editor Pop Up Window when merging bib data from web. May 15, 2022
@HoussemNasri
Copy link
Member

HoussemNasri commented May 27, 2022

The oversized merge dialog was fixed in #8599. @anton-vrba Can you please test the latest development build to see if you can still reproduce the issue?

@anton-vrba
Copy link
Author

anton-vrba commented May 28, 2022 via email

@ThiloteE
Copy link
Member

No error on my machine. So there must be more specific conditions for this error.

@anton-vrba
Copy link
Author

Can you give me a link to a .msi file. It is no great deal to uninstall and reinstall.

@Siedlerchr
Copy link
Member

@anton-vrba You find the latest version here also as msi https://builds.jabref.org/main/ (5.7...)

@anton-vrba
Copy link
Author

OK I see what is happening. The merge pop up has become very large and if the main window of JabRef is placed in the top left hand corner of the screen---where I like it--- the merge pop up is off-screen. Whereas if a place the main window in the bottom left corner of my screen, I get the enormous 1922 by 1163 pop up window.

If the pop up on your system has a different size it looks like uninitialized code to me.

The previous version's merge pop up were constrained within the JabRef main window.

@HoussemNasri
Copy link
Member

HoussemNasri commented May 30, 2022

For now, one solution could be to center the dialog on the screen. JavaFX has no direct method for centering a dialog, but we can use a workaround. In the future, we might consider adding the merge UI as a tab to the maintable, like IntelliJ and Eclipse. IntelliJ uses a tab for diffs and a dialog for resolving merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Normal priority
Development

No branches or pull requests

4 participants