-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception if linked file has masked umlauts / invalid characters in path (from Citavi export in my case) #8786
Comments
Hm. JabRef can't do anything about this when the file name is illegal... |
Yes, I understand that. I was mainly talking about the currently uncaught exception in such cases (which doesn't provide a good UX). |
@claell I am not sure what to do with this. Yes, we see there is a bug, but could you explain more about what you expect to be done with the UI? I think there was another issue that also complained about better error message UI. Maybe it should be discussed over there and this one should stay open as reference to the citavi importer? |
@ThiloteE Sorry, but this has nothing do with java special character. It's that Windows doesn't allow these characters in a fie name https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file and java Relevant part:
|
Thanks for the explanation Christoph. Similar (probably also unresolved) problem in #7381
|
Maybe we can also run Latex2Unicode on the file field... |
Hm, yes looks exactly as #7381 (#7381 (comment) also mentions that only the endless loops were fixed, while the issue still happens when accessing the entry information). |
The question is: Does JabRef want to support such things? Is this supported by BibTeX? Else it should probably show a warning, possibly also propose a fix. However, if BibTeX allows this stuff, then JabRef should work with it (possibly propose a change for better conformity with JabRef and consistency with the rest of the library). |
@claell Well, the path contains illegal characters in this way and JabRef (when generating file names) ensures it contains no illegal chars for every platform to make sure it's cross-platform, but does not check any existing files name fields. Solution:
Additionally: Add an integrity checker if any file name contains illegal chars jabref/src/main/java/org/jabref/logic/util/io/FileNameCleaner.java Lines 50 to 61 in bb011c9
|
Can I do this job?I am a new bee of opensource |
Sure :-) As a general advice: Check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at. Feel free to ask, if you have any questions here on GitHub or also at JabRef's Gitter chat. Try to open a (draft) pull request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
Hello, could you assign this to me? I think this issue is quite interesting. |
I have code as the instruction.But how can I verify it?
|
JabRef version
5.6 (latest release)
Operating system
Windows
Details on version and operating system
Windows 10
Checked with the latest development build
Steps to reproduce the behaviour
General
tabAppendix
Log File
The text was updated successfully, but these errors were encountered: