Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify button "Import and keep old entry" #9056

Closed
koppor opened this issue Aug 13, 2022 · 4 comments · Fixed by #9140
Closed

Clarify button "Import and keep old entry" #9056

koppor opened this issue Aug 13, 2022 · 4 comments · Fixed by #9140
Assignees

Comments

@koppor
Copy link
Member

koppor commented Aug 13, 2022

Refs #6190

The button text "Import and keep old entry" does not make it crystal clear, what happens.

My use case:

  1. Copy 120 entries (which are no duplicates) from a bib file
  2. Paste these entries in a new file
  3. The merge entries dialog pops up
  4. I want to keep both entries (and not creating a new one)

grafik

@koppor koppor changed the title Clarify button Clarify button "Import and keep old entry" Aug 13, 2022
@koppor koppor added the ui label Aug 13, 2022
@koppor
Copy link
Member Author

koppor commented Aug 13, 2022

Maybe, the call of the dialog is wrong. Sometimes, it is "Use both entries"

grafik

@Siedlerchr
Copy link
Member

Comes from pasting:
importHandler#importEntryWithDuplicateCheck -> calls the dialog with IMPORT_CHECK enum value which is not covered in the existing cases in the DuplicateResolverDialog

@HoussemNasri
Copy link
Member

There are 7 possible actions/strategies, one might choose to fast-merge entries, but in the duplicate resolver dialog, only 4 are provided ('Cancel' and 'Do not import entry' seems to do the same thing)

  • Keep Left
  • Keep Right
  • Keep Merged
  • Keep Left & Right
  • Keep Left & Merged
  • Keep Right & Merged
  • Keep Left & Right & Merged

I don't think we can fit 7 actions on the button bar. Even if we did it will look ugly. I believe that using Controlsfx's CheckComboBox would be a better solution. We add left, right and merged to the ComboBox and users can select whatever combination they like. We can also change left and right to Old entry and from Import if entries are imported.

image

@koppor
Copy link
Member Author

koppor commented Aug 16, 2022

I am in favor of:

  • Keep Merged (at the beginning, because this should be the best)
  • Keep Left
  • Keep Right
  • Keep Left & Right (this is only necessary, because our duplicate detection is not that good)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants