Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old Swing Screenshots with JavaFX ones #199

Open
Siedlerchr opened this issue Jan 24, 2019 · 6 comments
Open

Replace old Swing Screenshots with JavaFX ones #199

Siedlerchr opened this issue Jan 24, 2019 · 6 comments
Labels
good first issue Good first issue for newcomers

Comments

@Siedlerchr
Copy link
Member

Check through the help which dialogs need replacement
For example the diff/merge dialog

@Siedlerchr Siedlerchr changed the title Replace old Swing Screenshots Replace old Swing Screenshots with JavaFX ones Jan 24, 2019
@Siedlerchr Siedlerchr added the good first issue Good first issue for newcomers label Jan 24, 2019
@sameshl
Copy link

sameshl commented Oct 6, 2019

@Siedlerchr I would love to work on this. But I haven't quite understood what I am supposed to do here. Could you please elaborate a bit.

Thanks!

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Oct 6, 2019

Thanks for your interest, the help pages contain old Screenshots. In the current 5.x development version the user interface has been changed and dialogs look a bit different now
So it would be cool to replace the old Screenshots with new ones

You can get the latest development version of JabRef at builds.jabref.org

@Siedlerchr Siedlerchr reopened this Oct 6, 2019
@tobiasdiez
Copy link
Member

In the best case, we should add unit gui tests and use testfx's DebugUtil.captureScreenshot to automate this. Then it would be easy to always have updated screenshots.

@bulkpool
Copy link

bulkpool commented Oct 6, 2020

@koppor I would love to work on this issue. But this is my first time contributing in an organization. Could please elaborate on how do I contribute to this issue and where do I get the files of the program.

@koppor
Copy link
Member

koppor commented Oct 7, 2020

You chose a difficult one, but a good thing to learn about testing and JavaFX. One start can be JabRef/jabref#6089 (comment).

@Siedlerchr
Copy link
Member Author

Update: It's okay to not write GUI tests, but instead manually replace the screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issue for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants