Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicates imports #41

Open
asmrtfm opened this issue Jan 5, 2025 · 1 comment
Open

duplicates imports #41

asmrtfm opened this issue Jan 5, 2025 · 1 comment
Assignees

Comments

@asmrtfm
Copy link

asmrtfm commented Jan 5, 2025

When you add additional hotfolders,the perceived behavior is as if it is cloning the plugin with current settings included (which includes whatever notebook and directory the user had specified there in the base plugin's options).

whether that's a bug or a feature, it has the effect of duplicating all of those imports, presumably because it does not wait for the new hotfolder to be configured before executing its import actions.

propsals:

  • have a single hotfolder plugin options window.
  • spawn pairs of additional input fields for additional directories and corresponding notebook.
  • eliminate default auto import to all-notes section and any associated functionality entirely.
  • only execute hotloading when both the directory and its corresponding notebook field are populated.
  • if user specifies an invalid path, inform them and do not commit the change upon apply - the same goes for the corresponding notebook field.
  • If these values were valid during creation but become invalid later, show indicator inside the hotfolder options page instead of constantly throwing an error.
@JackGruber
Copy link
Owner

After creating another hotfolder, Joplin must be restarted so that this hotfolder appears in the menu.
Dynamic changes in the plugin settings are not possible with the Joplin API, so a restart is necessary.
And no, the path for the hotfolder is not cloned and the other values have the default ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants