Game crashes when opening Controls GUI

[ephys]

I'm getting a weird crash that is really hard to track down. It doesn't mention this mod specifically but only occur when this mod is loaded.

Here is the crash report: https://gist.github.com/Ephys/597a64c9b14761a6c67b0a9996c3c51e

I think it may be related to StrikerRockers-Mods/VanillaTweaks#19 -- I had the exact same issue with that mod alone too.

[JackyyTV]

That's very strange. Does that happen every time or just at occasions?

[ephys]

Happened every time as soon as the GUI was opened

Edit: This might be interesting, I disabled infinityArmorNoClip in the config. I'll try with it on

[ephys]

Definitely interesting, the crash only happens if infinityArmorNoClip is false. Maybe creating the keybind but not registering it is the source of the crash?

[JackyyTV]

Might be something to do with the keybind, I think I should always register the keybind but only disable No Clip mode for ingame.

[ephys]

Or only instanciate the KeyBind if it's going to be registered. It doesn't look like it's being referenced from anywhere in the code so it shouldn't be an issue

[JackyyTV]

I am actually.

AvaritiaTweaks/src/main/java/jackyy/avaritiatweaks/tweaks/ModEventsHandler.java

Lines 157 to 162 in 8e8a873

	@SubscribeEvent @SideOnly(Side.CLIENT)
	public void onKeyInput(InputEvent.KeyInputEvent event) {
	if (Keys.NOCLIP.isPressed()) {
	PacketHandler.INSTANCE.sendToServer(new PacketToggleNoClip());
	}
	}

But it's fine, that can be fixed quite easily.

[JackyyTV]

New version coming out in a few hours, hopefully should fix your problems.

[ephys]

Thank youu!