Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The evils of emptyN #385

Closed
JacquesCarette opened this issue Aug 12, 2017 · 1 comment
Closed

The evils of emptyN #385

JacquesCarette opened this issue Aug 12, 2017 · 1 comment
Assignees
Labels
bug design Related to the current design of Drasil (not artifacts). High Priority

Comments

@JacquesCarette
Copy link
Owner

In 668bc55, @niazim3 correctly spotted a pattern, abstracted it out, and introduced emptyN in Language.Drasil.Chunk.Reqs for it.

But it, (somewhat like emptyS, in fact), is really bad [its use, not its abstraction]. When we have a field, we should fill it with something meaningful. If we consistently fill it with junk, then it means either

  1. our design for that data-structure is flawed
  2. our use of that concept is flawed

I believe that the problem here is actually a mixture of both!

ReqChunk is not about requirements at all. It is used merely to record module dependencies. Worse still: these dependencies are human-declared and not inferred! So there is not meaningful content to put in the NamedIdea of a ReqChunk because it isn't a "named idea".

[This actually points to a set of larger flaws we have, where what we declare as modules is completely independent of the modules generated. Furthermore, there is another disconnect where the requirements we declare are not really linked to the modules we declare. Traceability nightmare.]

@JacquesCarette JacquesCarette added bug design Related to the current design of Drasil (not artifacts). High Priority labels Aug 12, 2017
@szymczdm
Copy link
Collaborator

Now that we've scrapped the original MG generation (and I just removed the last mentions of it from our examples in commit b9c17c9 ) I believe this one's fixed since ReqChunks are no longer actually in use and those were the only instances of "emptyN" (which has now been removed).

The rest of this issue will be handled by #430 and #417 (Module chunk generation), so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Related to the current design of Drasil (not artifacts). High Priority
Projects
None yet
Development

No branches or pull requests

4 participants