-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infer units of quantities #498
Comments
@JacquesCarette Hello Dr. Carette is there any way for me to help with this issue? I've looked through #377 and the |
Eventually, yes. However, @halonazhao is working on things relating to units right now, and so it would be quite dangerous to do this in parallel. The likelyhood of a difficult merge are way too high. |
So, I'm not immediately sure why we want to infer units of quantities. Is it to check that a symbol declaration's unit matches the unit of an expression we're trying to equate it to? |
Yes, it is all about checking coherence. Some expressions might well have units that don't make sense (the same way things can be ill-typed). |
This was started by @AKM11 (see #377 for some details, and code in
Language.Drasil.Misc
), but not quite finished. Definitely a good feature to have. As #377 what about a different problem, I'm going to close that one, and the current issue is for remembering to finish the feature itself.The text was updated successfully, but these errors were encountered: