Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer units of quantities #498

Open
JacquesCarette opened this issue May 8, 2018 · 4 comments
Open

infer units of quantities #498

JacquesCarette opened this issue May 8, 2018 · 4 comments
Labels
enhancement needs-action-items A clear 'path to resolution' is needed to close any ticket.

Comments

@JacquesCarette
Copy link
Owner

This was started by @AKM11 (see #377 for some details, and code in Language.Drasil.Misc), but not quite finished. Definitely a good feature to have. As #377 what about a different problem, I'm going to close that one, and the current issue is for remembering to finish the feature itself.

@elwazana
Copy link
Collaborator

@JacquesCarette Hello Dr. Carette is there any way for me to help with this issue?

I've looked through #377 and the Language.Drasil.Misc file's relevant code; if I can work on finishing this issue, I would like some clarification on what exactly needs finishing in the feature as you mentioned above as that is still unclear to me.

@JacquesCarette
Copy link
Owner Author

Eventually, yes. However, @halonazhao is working on things relating to units right now, and so it would be quite dangerous to do this in parallel. The likelyhood of a difficult merge are way too high.

@balacij
Copy link
Collaborator

balacij commented Jul 21, 2024

So, I'm not immediately sure why we want to infer units of quantities. Is it to check that a symbol declaration's unit matches the unit of an expression we're trying to equate it to?

@JacquesCarette
Copy link
Owner Author

Yes, it is all about checking coherence. Some expressions might well have units that don't make sense (the same way things can be ill-typed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-action-items A clear 'path to resolution' is needed to close any ticket.
Projects
None yet
Development

No branches or pull requests

3 participants