-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Figures should have Figure X:
in their figcaption
and references to figures should be prettier.
#702
Comments
A similar (but different) thing happened with tables (#833), and I think (at least for now) we're OK with it. This came up now because I'm removing a function that created a |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Figure:
in their figcaption
and references to figures should be prettier.
Figure:
in their figcaption
and references to figures should be prettier.Figure X:
in their figcaption
and references to figures should be prettier.
The underlying infrastructure should provide the consistent numbers - we just have to provide consistent labels. |
The generator for LaTeX should be different from the html generator. The word Figure shouldn't be added in the LaTeX version. @JacquesCarette alluded to the underlying numbering system. Is there one for the html version? If there is, you could use it. If not, maybe we don't need numbers for the html version? They hyperlinks do the same job. Do we have hyperlinks in the LaTeX version? It looks like we do from the screenshots given above. |
Currently, HTML does not have a numbering system. Adding the prefix "Figure:" could lead to the conflict mentioned earlier. |
Yes @TRISHI-L it is a good idea to investigate in more depth how both the HTML and LaTeX renderers work, and how they are different. This isssue is a bit subtle. I think that we chose to use symbolic links in HTML (rather than numbers) as those tend to be more meaningful for human readers. |
@Xinlu-Y, the relevant package for this issue is Drasil/code/drasil-printers/lib/Language/Drasil/HTML/Helpers.hs Lines 141 to 150 in 8ca26be
Similarly, it would probably be nice to add this change to mdBook as well. Here is the function for setting up figures in mdBook: Drasil/code/drasil-printers/lib/Language/Drasil/Markdown/Helpers.hs Lines 63 to 67 in 8ca26be
|
EDIT: Take Projectile's SRS for example. Specifically, the System Context Figure. We have ~2-3 issues:
Figure:
text in their captions.Fig:sysCxtDiag
.@smiths Do you have any thoughts on whether this we should use a numbering system or a short-caption?
Original OP:
center
environment. ~~The text was updated successfully, but these errors were encountered: