Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write.php > overwrite_tags = false - solution (more testing required) #282

Open
benarcher4 opened this issue Jan 5, 2021 · 0 comments
Open
Labels
new feature request Planned Feature or New Feature Request tag writing

Comments

@benarcher4
Copy link

benarcher4 commented Jan 5, 2021

In write.php in MergeExistingTagData() using array_replace_recursive() instead of array_merge_recursive() has done the trick for me - though I've only tested FLAC files.

So long as getID3 is pulling all the tags into $this->ThisFileInfo['tags'][$TagFormat] there should be no loss of data or malformation of the array as with the old code.

$tag_data = array_replace_recursive($this->ThisFileInfo['tags'][$TagFormat],$tag_data);

Sadly this bumps up version requirements to PHP 5 >= 5.3.0, PHP 7.

Apologies for putting this in as an Issue. The support forum has been closed to new registrations and I don't have time to commit new code, but thought it important to make a note given the number of issues raised on the project on this point.

@StudioMaX StudioMaX added the new feature request Planned Feature or New Feature Request label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request tag writing
Projects
None yet
Development

No branches or pull requests

3 participants