feat(diagnostics): report on TS 1096 (#110)

Author: armano2

src/semantic-errors.ts

@@ -60,6 +60,7 @@ function whitelistSupportedDiagnostics(
       case 1048: // ts 3.2 "A rest parameter cannot have an initializer."
       case 1049: // ts 3.2 "A 'set' accessor must have exactly one parameter."
       case 1090: // ts 3.2 "'{0}' modifier cannot appear on a parameter."
+      case 1096: // ts 3.2 "An index signature must have exactly one parameter."
       case 1097: // ts 3.2 "'{0}' list cannot be empty."
       case 1117: // ts 3.2 "An object literal cannot have multiple properties with the same name in strict mode."
       case 1121: // ts 3.2 "Octal literals are not allowed in strict mode."

tests/ast-alignment/fixtures-to-test.ts

@@ -194,6 +194,12 @@ tester.addFixturePatternConfig('javascript/experimentalOptionalCatchBinding');
 tester.addFixturePatternConfig('javascript/for');
 tester.addFixturePatternConfig('javascript/forIn', {
   ignore: [
+    /**
+     * Error: AST difference
+     * ts-estree: ArrayPattern
+     * babel: ArrayExpression
+     */
+    'for-in-array',
     /**
      * Error: AST difference
      * ts-estree: AssignmentExpression
@@ -213,7 +219,16 @@ tester.addFixturePatternConfig('javascript/forIn', {
   ]
 });
 
-tester.addFixturePatternConfig('javascript/forOf');
+tester.addFixturePatternConfig('javascript/forOf', {
+  ignore: [
+    /**
+     * Error: AST difference
+     * ts-estree: ArrayPattern
+     * babel: ArrayExpression
+     */
+    'for-of-array'
+  ]
+});
 tester.addFixturePatternConfig('javascript/generators');
 tester.addFixturePatternConfig('javascript/globalReturn');
 tester.addFixturePatternConfig('javascript/importMeta');
@@ -336,6 +351,15 @@ tester.addFixturePatternConfig('typescript/basics', {
     'class-with-implements-generic',
     'class-with-implements',
     'class-with-extends-and-implements',
+    /**
+     * Babel error: parameterName is not included into range of TSTypeAnnotation
+     * TODO: report it to babel
+     */
+    'type-guard-in-method',
+    /**
+     * there is difference in range between babel and ts-estree
+     */
+    'export-declare-const-named-enum',
     /**
      * Other major AST differences (e.g. fundamentally different node types)
      */
@@ -349,10 +373,18 @@ tester.addFixturePatternConfig('typescript/basics', {
     'interface-with-jsdoc',
     'interface-with-optional-properties',
     'interface-without-type-annotation',
+    'interface-with-method',
+    'type-guard-in-interface',
+    'typed-method-signature',
     'typed-this',
+    /**
+     * Babel bug for parsing exported abstract interface
+     * https://github.com/babel/babel/issues/9304
+     */
     'abstract-interface',
     /**
-     * Babel bug for optional or abstract methods?
+     * Babel bug for optional or abstract methods
+     * https://github.com/babel/babel/issues/9305
      */
     'abstract-class-with-abstract-method', // babel parse errors
     'abstract-class-with-optional-method', // babel parse errors
@@ -366,8 +398,8 @@ tester.addFixturePatternConfig('typescript/basics', {
     'class-with-public-parameter-properties',
     'class-with-readonly-parameter-properties',
     /**
-     * Not yet supported in Babel https://github.com/babel/babel/issues/7749
-     * WIP PR is https://github.com/babel/babel/pull/8798
+     * PR for type import has been merged into Babel: https://github.com/babel/babel/pull/9302
+     * TODO: remove me in next babel > 7.2.3
      */
     'import-type',
     'import-type-with-type-parameters-in-type-reference',
@@ -444,7 +476,10 @@ tester.addFixturePatternConfig('typescript/types', {
      * AST difference
      */
     'function-with-rest',
-    'constructor-with-rest'
+    'constructor-with-rest',
+    'index-signature',
+    'index-signature-readonly',
+    'literal-number-negative'
   ]
 });
 

tests/fixtures/javascript/forIn/for-in-array.src.js

@@ -0,0 +1 @@
+for (i in []) {}

tests/fixtures/javascript/forIn/for-in-destruction-object.src.js

@@ -0,0 +1 @@
+for (var {name, value} in obj) {}

tests/fixtures/javascript/forIn/for-in-object-with-body.src.js

@@ -0,0 +1 @@
+for (i in {}) {}

tests/fixtures/javascript/forOf/for-of-array.src.js

@@ -0,0 +1,2 @@
+for (let x of [])
+    doSomething();

tests/fixtures/javascript/forOf/for-of-destruction-object.src.js

@@ -0,0 +1 @@
+for (var {name, value} of obj) {}

tests/fixtures/javascript/forOf/for-of-destruction.src.js

@@ -0,0 +1 @@
+for (var [name, value] of obj) {}

tests/fixtures/javascript/forOf/for-of-object.src.js

@@ -0,0 +1,2 @@
+for (let x of {})
+    doSomething();

tests/fixtures/typescript/basics/export-declare-const-named-enum.src.ts

@@ -0,0 +1,4 @@
+export declare const enum Foo {
+    foo = 1,
+    bar
+}