feat: allow custom id strategies #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLMilner
force-pushed
the
id-strategy
branch
2 times, most recently
from
e50bbcb to
e8056ee
Compare
JamesLMilner
force-pushed
the
id-strategy
branch
from
e8056ee to
16d1897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
It has historically not been possible to use your own IDs with Terra Draw as they would always be created with UUIDv4. This is generally fine, but there are scenarios were people may want to bring their own id creation strategy along, and not use UUIDv4. This PR allows for that.
Link to Issue
#179
PR Checklist