Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Make the rule File Content Regex print the offending lines #31

Closed
acecilia opened this issue Aug 15, 2019 · 1 comment · Fixed by #32
Closed

Make the rule File Content Regex print the offending lines #31

acecilia opened this issue Aug 15, 2019 · 1 comment · Fixed by #32
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@acecilia
Copy link
Contributor

acecilia commented Aug 15, 2019

At the moment the printed errors are not very informative, and is impossible to find the offending line. For example:

/../../../ExampleApp/ExampleApp/Resources/en.lproj/Localizable.strings:-1: ProjLint:  File Content Regex Violation – Content matched regex 'Regex<"\n"(?!((([A-Z][a-z ]*)" = "\3")|(L\.[a-z][a-zA-Z]+" = ".+"));)">' where it shouldn't.

It will be very helpful if the error shows the offending line.

This issue seems to be also related to #29

@Jeehut
Copy link
Contributor

Jeehut commented Aug 16, 2019

Thanks for reporting the issue. You're right, there are many things that can be improved within this project and this is one of those things. Feel free to post a PR with a fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants