Jetty 11 integration #951

moabu · 2022-03-02T19:21:36Z

moabu
Mar 2, 2022
Maintainer

@yuriyz , @yurem , @pujavs , @jgomer2001 @nynymike @mbaser

We need to work on integrating jetty 11 to reduce the security vulnerabilities and also increase performance.

https://artifacthub.io/packages/helm/janssen-auth-server/janssen?modal=security-report

This requires some changes in the code . Take a look at this issue .

https://stackoverflow.com/a/66368511

iromli · 2022-03-02T19:27:20Z

iromli
Mar 2, 2022
Collaborator

Here's logs from auth-server running on Jetty 11:

jans/jetty/jans-auth/webapps/jans-auth/, jar:file:///opt/jans/jetty/jans-auth/webapps/jans-auth/WEB-INF/lib/bootsfaces-1.4.1.jar!/META-INF/resources, 
jar:file:///opt/jans/jetty/jans-auth/webapps/jans-auth/WEB-INF/lib/jans-auth-static-1.0.0-SNAPSHOT.jar!/META-INF/resources, jar:file:///opt/jans/jetty
/jans-auth/webapps/jans-auth/WEB-INF/lib/omnifaces-2.6.9.jar!/META-INF/resources, jar:file:///opt/jans/jetty/jans-auth/webapps/jans-auth/WEB-INF/lib/j
akarta.faces-2.3.14.jar!/META-INF/resources],UNAVAILABLE}{/opt/jans/jetty/jans-auth/webapps/jans-auth}
java.lang.NoClassDefFoundError: javax/servlet/ServletRequestListener
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(Unknown Source)
        at java.base/java.security.SecureClassLoader.defineClass(Unknown Source)
        at java.base/java.net.URLClassLoader.defineClass(Unknown Source)
        at java.base/java.net.URLClassLoader$1.run(Unknown Source)
        at java.base/java.net.URLClassLoader$1.run(Unknown Source)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at java.base/java.net.URLClassLoader.findClass(Unknown Source)
        at org.eclipse.jetty.webapp.WebAppClassLoader.foundClass(WebAppClassLoader.java:594)
        at org.eclipse.jetty.webapp.WebAppClassLoader.loadAsResource(WebAppClassLoader.java:567)
        at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:502)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
        at org.eclipse.jetty.server.handler.ContextHandler$Context.addListener(ContextHandler.java:2475)
        at org.eclipse.jetty.servlet.ServletContextHandler$Context.addListener(ServletContextHandler.java:1502)
        at org.apache.jasper.servlet.JasperInitializer.onStartup(JasperInitializer.java:92)
        at org.eclipse.jetty.servlet.ServletContainerInitializerHolder.doStart(ServletContainerInitializerHolder.java:148)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.servlet.ServletContextHandler$ServletContainerInitializerStarter.doStart(ServletContextHandler.java:1660)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:369)
        at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1305)
  at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:896)
        at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:306)
        at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:533)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.bindings.StandardStarter.processBinding(StandardStarter.java:40)
        at org.eclipse.jetty.deploy.AppLifeCycle.runBindings(AppLifeCycle.java:183)
        at org.eclipse.jetty.deploy.DeploymentManager.requestAppGoal(DeploymentManager.java:516)
        at org.eclipse.jetty.deploy.DeploymentManager.addApp(DeploymentManager.java:151)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.fileAdded(ScanningAppProvider.java:186)
        at org.eclipse.jetty.deploy.providers.WebAppProvider.fileAdded(WebAppProvider.java:462)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider$1.fileAdded(ScanningAppProvider.java:58)
        at org.eclipse.jetty.util.Scanner$DiscreteListener.pathAdded(Scanner.java:282)
        at org.eclipse.jetty.util.Scanner.reportAddition(Scanner.java:836)
        at org.eclipse.jetty.util.Scanner.reportDifferences(Scanner.java:802)
        at org.eclipse.jetty.util.Scanner.scan(Scanner.java:709)
        at org.eclipse.jetty.util.Scanner.doStart(Scanner.java:597)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.doStart(ScanningAppProvider.java:158)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.DeploymentManager.startAppProvider(DeploymentManager.java:605)
        at org.eclipse.jetty.deploy.DeploymentManager.doStart(DeploymentManager.java:246)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.server.Server.start(Server.java:469)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89)
        at org.eclipse.jetty.server.Server.doStart(Server.java:414)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.xml.XmlConfiguration.lambda$main$4(XmlConfiguration.java:1872)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at org.eclipse.jetty.xml.XmlConfiguration.main(XmlConfiguration.java:1810)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.base/java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.jetty.start.Main.invokeMain(Main.java:228)
        at org.eclipse.jetty.start.Main.start(Main.java:513)
        at org.eclipse.jetty.start.Main.main(Main.java:75)
Caused by: 
java.lang.ClassNotFoundException: javax.servlet.ServletRequestListener
        at java.base/java.net.URLClassLoader.findClass(Unknown Source)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
        at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:511)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(Unknown Source)
        at java.base/java.security.SecureClassLoader.defineClass(Unknown Source)
        at java.base/java.net.URLClassLoader.defineClass(Unknown Source)
        at java.base/java.net.URLClassLoader$1.run(Unknown Source)
        at java.base/java.net.URLClassLoader$1.run(Unknown Source)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at java.base/java.net.URLClassLoader.findClass(Unknown Source)
        at org.eclipse.jetty.webapp.WebAppClassLoader.foundClass(WebAppClassLoader.java:594)
        at org.eclipse.jetty.webapp.WebAppClassLoader.loadAsResource(WebAppClassLoader.java:567)
        at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:502)
        at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
at org.eclipse.jetty.server.handler.ContextHandler$Context.addListener(ContextHandler.java:2475)
        at org.eclipse.jetty.servlet.ServletContextHandler$Context.addListener(ServletContextHandler.java:1502)
        at org.apache.jasper.servlet.JasperInitializer.onStartup(JasperInitializer.java:92)
        at org.eclipse.jetty.servlet.ServletContainerInitializerHolder.doStart(ServletContainerInitializerHolder.java:148)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
        at org.eclipse.jetty.servlet.ServletContextHandler$ServletContainerInitializerStarter.doStart(ServletContextHandler.java:1660)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:369)
        at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1305)
        at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:896)
        at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:306)
        at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:533)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.bindings.StandardStarter.processBinding(StandardStarter.java:40)
        at org.eclipse.jetty.deploy.AppLifeCycle.runBindings(AppLifeCycle.java:183)
        at org.eclipse.jetty.deploy.DeploymentManager.requestAppGoal(DeploymentManager.java:516)
        at org.eclipse.jetty.deploy.DeploymentManager.addApp(DeploymentManager.java:151)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.fileAdded(ScanningAppProvider.java:186)
        at org.eclipse.jetty.deploy.providers.WebAppProvider.fileAdded(WebAppProvider.java:462)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider$1.fileAdded(ScanningAppProvider.java:58)
        at org.eclipse.jetty.util.Scanner$DiscreteListener.pathAdded(Scanner.java:282)
        at org.eclipse.jetty.util.Scanner.reportAddition(Scanner.java:836)
        at org.eclipse.jetty.util.Scanner.reportDifferences(Scanner.java:802)
        at org.eclipse.jetty.util.Scanner.scan(Scanner.java:709)
        at org.eclipse.jetty.util.Scanner.doStart(Scanner.java:597)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.deploy.providers.ScanningAppProvider.doStart(ScanningAppProvider.java:158)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.deploy.DeploymentManager.startAppProvider(DeploymentManager.java:605)
        at org.eclipse.jetty.deploy.DeploymentManager.doStart(DeploymentManager.java:246)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171)
        at org.eclipse.jetty.server.Server.start(Server.java:469)
        at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121)
        at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89)
        at org.eclipse.jetty.server.Server.doStart(Server.java:414)
        at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
        at org.eclipse.jetty.xml.XmlConfiguration.lambda$main$4(XmlConfiguration.java:1872)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at org.eclipse.jetty.xml.XmlConfiguration.main(XmlConfiguration.java:1810)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.base/java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.jetty.start.Main.invokeMain(Main.java:228)
        at org.eclipse.jetty.start.Main.start(Main.java:513)
        at org.eclipse.jetty.start.Main.main(Main.java:75)

0 replies

jgomer2001 · 2022-03-02T19:30:19Z

jgomer2001
Mar 2, 2022
Maintainer

jans and gluu install supports jetty-11

main issue is to find working mix of libs

We can upgrade:

weld 5 (it's cdi 3.0) which works with jakarta
resteasy 6? (Jakarta RESTful Web Services 3.0)

0 replies

pujavs · 2022-03-03T07:39:18Z

pujavs
Mar 3, 2022
Maintainer

Upgrading Jans Jetty projects to Jetty 11

Jetty 11 is major change as a result of the move from Java EE to Jakarta EE as part of the transfer of Java EE to the Eclipse Foundation, the primary package for all implemented APIs has changed from javax.* to jakarta.*.
This will almost certainly require code changes to enable applications to migrate to Jetty 11.x and later
Details can be found here

Analysis:
A) lib upgrade required

jetty
jakarta.servlet-api
weld

B) Finding:

Exiting code with jetty upgrade to 11.0.8 & weld 4.0.3.Final gives java.lang.ClassNotFoundException: javax.servlet.ServletRequestListener Logs: 2022_03_01.jetty.log
With jetty upgrade to 11.0.8, weld 4.0.3.Final & jakarta.servlet-api 4.0.4 gives org.xml.sax.SAXParseException; lineNumber: 8; columnNumber: 26; Attribute value "webAppCtx" of type ID must be unique within the document. Logs: 2022_03_02.jetty.log
With jetty upgrade to 11.0.8, weld 4.0.3.Final & jakarta.servlet-api 5.0.0 we get compile error due to namespace change from javax to jakarta from jakarta.servlet-api 5.0.0 onwards
Logs: compile_error.log

0 replies

moabu · 2022-03-03T09:23:15Z

moabu
Mar 3, 2022
Maintainer Author

We are tracking changes in https://github.com/JanssenProject/jans/tree/jans-jetty-upgrade

1 reply

yuriyz Mar 3, 2022
Maintainer

I propose to move to stable 4.0.3.Final. In this case we will get namespace updated and can move to newer jetty. Switching to next Weld would be easier and we don't become beta testers of Weld 5.x release candidate.

yuriyz · 2022-03-03T09:51:42Z

yuriyz
Mar 3, 2022
Maintainer

Important is to target particular Weld and resteasy version so we don't mess classpath. During this migration we should discover all places where we don't rely on jans-bom.

0 replies

pujavs · 2022-03-04T06:50:28Z

pujavs
Mar 4, 2022
Maintainer

Jetty_Upgrade_Details.xlsx: Jetty_Upgrade_Details.xlsx

List of lib to be replaced due to transition from Java EE to Jakarta

0 replies

moabu · 2022-03-26T10:11:36Z

moabu
Mar 26, 2022
Maintainer Author

Getting there... https://github.com/JanssenProject/jans/tree/jans-jetty-upgrade

We should be able to get this in quickly

0 replies

moabu · 2022-03-31T11:36:40Z

moabu
Mar 31, 2022
Maintainer Author

building docker images and scanning....

0 replies

moabu · 2022-04-29T08:44:15Z

moabu
Apr 29, 2022
Maintainer Author

jetty 11 made it to our main branch!

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jetty 11 integration #951

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 9 comments 1 reply

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Jetty 11 integration #951

moabu Mar 2, 2022 Maintainer

Replies: 9 comments · 1 reply

iromli Mar 2, 2022 Collaborator

jgomer2001 Mar 2, 2022 Maintainer

pujavs Mar 3, 2022 Maintainer

Upgrading Jans Jetty projects to Jetty 11

moabu Mar 3, 2022 Maintainer Author

yuriyz Mar 3, 2022 Maintainer

yuriyz Mar 3, 2022 Maintainer

pujavs Mar 4, 2022 Maintainer

List of lib to be replaced due to transition from Java EE to Jakarta

moabu Mar 26, 2022 Maintainer Author

moabu Mar 31, 2022 Maintainer Author

moabu Apr 29, 2022 Maintainer Author

moabu
Mar 2, 2022
Maintainer

Replies: 9 comments 1 reply

iromli
Mar 2, 2022
Collaborator

jgomer2001
Mar 2, 2022
Maintainer

pujavs
Mar 3, 2022
Maintainer

moabu
Mar 3, 2022
Maintainer Author

yuriyz Mar 3, 2022
Maintainer

yuriyz
Mar 3, 2022
Maintainer

pujavs
Mar 4, 2022
Maintainer

moabu
Mar 26, 2022
Maintainer Author

moabu
Mar 31, 2022
Maintainer Author

moabu
Apr 29, 2022
Maintainer Author