Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support regex client attribute to validate redirect uris #1005

Merged
merged 5 commits into from
Mar 11, 2022

Conversation

Milton-Ch
Copy link
Contributor

Description

  1. Added client attribute to validate redirect uris using a regex.
  2. Added feature flag redirectUrisRegexEnabled.

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Milton-Ch Milton-Ch marked this pull request as ready for review March 10, 2022 12:44
Copy link
Contributor

@yuriyz yuriyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor feedback in inlined comments.

@Milton-Ch Milton-Ch requested a review from yuriyz March 11, 2022 03:01
@Milton-Ch Milton-Ch enabled auto-merge (squash) March 11, 2022 03:06
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2022

[Jans authentication server parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability B 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Milton-Ch Milton-Ch merged commit a78ee1a into main Mar 11, 2022
@Milton-Ch Milton-Ch deleted the feat/redirect-uri-regex branch March 11, 2022 11:59
Copy link
Contributor

@pujavs pujavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants