Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Validate redirect_uri blank and client redirect uris single item #1046

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fix: Validate redirect_uri blank and client redirect uris single item #1046

merged 1 commit into from
Mar 15, 2022

Conversation

Milton-Ch
Copy link
Contributor

Description

  1. Fixing redirect_uri validator issue when single item is in client redirect uris and param received is blank.
  2. Enabling redirectUrisRegexEnabled to run test in Jenkins.

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

yuriyz
yuriyz previously approved these changes Mar 15, 2022
View reviewed changes
@yuriyz yuriyz marked this pull request as ready for review March 15, 2022 08:11
@yuriyz
Copy link
Contributor

yuriyz commented Mar 15, 2022

@Milton-Ch commit is not signed

@Milton-Ch Milton-Ch force-pushed the fix/redirect-uri-single-uri-without-client-redirect-uris branch from c8254ef to db3bc9d Compare March 15, 2022 16:16
@Milton-Ch
Copy link
Contributor Author

All tests passed, build: https://jenkins.jans.io/jenkins/job/jans-auth-server/5838/
image

@yuriyz yuriyz merged commit aa139e4 into main Mar 15, 2022
@yuriyz yuriyz deleted the fix/redirect-uri-single-uri-without-client-redirect-uris branch March 15, 2022 16:20
@mo-auto mo-auto mentioned this pull request May 18, 2022
Merged
This was referenced May 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@smansoft smansoft Awaiting requested review from smansoft

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milton-Ch @yuriyz