fix: avoid duplicated client when re-running persistence-loader and configurator #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iromli
added
kind-bug
moabu
approved these changes
Mar 31, 2022
This was referenced May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overview:
configurator(previously they are created inpersistence-loaderinstead)Target issue
#1133
Implementation Details
The changeset guarantees client ID and secrets are created upfront in
configuratorso they can be exported intoconfig.jsonandsecret.json. Note this only work in fresh installation.For installation upgrade, make sure to run
janssenproject/configurator dumpto pull latest config and secrets intoconfig.jsonandsecret.json. Afterwards, proceed to upgrading images