Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors adding/upgrading data into couchbase persistence #1226

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Apr 19, 2022

Description

The changeset fixes 2 errors found while using Couchbase persistence:

  1. Some entries are placed into incorrect bucket
  2. Loading role mapping from persistence throws TypeError

Implementation Details

  1. Trailing comma must be added into the tuple (i.e. ("tokens_",) instead of ("tokens_")) to ensure key prefix is checked against a tuple (not a list of characters)
  2. Load role mapping from persistence using json.loads if it's a JSON string, otherwise use the role mapping directly

@iromli iromli requested a review from moabu as a code owner April 19, 2022 17:39
@mo-auto mo-auto added comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants