Util.getNumberOfSecondFromNow is calculating the delta incorrectly

[Milton-Ch]

Util.getNumberOfSecondsFromNow is calculating incorrectly the difference between current and param dates. After testing this locally these were the results:

    @Test
    public void calcTimeDiff() {
        Date time = DateUtils.setYears(new Date(), 2023);
        time = DateUtils.setMonths(time, 3);
        time = DateUtils.setDays(time, 20);
        System.out.println(time);
        int result = Util.getNumberOfSecondFromNow(time);
        System.out.println("Difference calculated using Util.getNumberOfSecondFromNow = " + result);

        System.out.println("Difference using Duration class = " + Duration.between(new Date().toInstant(), time.toInstant()).getSeconds());
    }

Result:

Thu Apr 20 14:48:34 BOT 2023
Difference calculated using Util.getNumberOfSecondFromNow = 1471228
Difference using Duration class = 31535999

@yuriyz Do you agree that we could use java.time.Duration instead?

[yuriyz]

@Milton-Ch yes, please. Check also tests why it didn't flag this bug.

[yuriyz]

It is casts problem, this gives correct result:

final long diff = time - now;
return (int) (diff / 1000L);

Anyway, better to stick to standard classes like Duration which are well tested.

[yuriyz]

Closing, this is fixed already.