Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update persistence schema and entry #1270

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix: update persistence schema and entry #1270

merged 1 commit into from
Apr 28, 2022

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Apr 28, 2022 •
edited
Loading

Description

Overview:

  1. Added missing permission and defaultPermissionInToken attribute in role-scope mapping

  2. Changed jansCodeChallengeHash column type (from TEXT to INT)

Implementation Details

  1. Entrypoint loads role-scope-mappings.json to compare to role-scope permissions in persistence. Any missing permission will be added into persistence. The same rule applied to missing defaultPermissionToken attribute.

    Ref: d61be0b

  2. The jansCodeChallengeHash column type is changed to INT (previously a TEXT type).

    Ref: 369129d

@iromli
fix: add missing permission and defaultPermissionInToken attribute in…
08dbb5e 
… role-scope mapping

fix: change jansCodeChallengeHash column type
@iromli iromli requested a review from moabu as a code owner April 28, 2022 19:03
@mo-auto mo-auto added comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality labels Apr 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@moabu moabu merged commit e2c67ec into main Apr 28, 2022
@moabu moabu deleted the cn-persistence-update branch April 28, 2022 20:28
@mo-auto2 mo-auto2 mentioned this pull request May 18, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
comp-docker-jans-persistence-loader kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iromli @moabu @mo-auto