Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-config-api): converting fido2 endpoint to plugin #1304

Merged
merged 6 commits into from
May 10, 2022
Merged

feat(jans-config-api): converting fido2 endpoint to plugin #1304

merged 6 commits into from
May 10, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented May 6, 2022 •
edited
Loading

@yuriyz request you to please review and approve changes for;

1. Enhancement: Fido2 plugin changes. Related issue 1224 and 1303
1.1) config-api: Moved fido2 endpoint and test cases to plugin and related swagger changes
1.2) jans-cli: fido2 related yaml changes

2.Fix:
2.1) config-api: Rectified user resource api protection scope for GET in rest service

@mo-auto mo-auto added comp-jans-cli-tui Component affected by issue or PR comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request labels May 6, 2022
yuriyz
yuriyz previously approved these changes May 6, 2022
View reviewed changes
devrimyatar
devrimyatar previously approved these changes May 10, 2022
View reviewed changes
@devrimyatar devrimyatar dismissed stale reviews from yuriyz and themself via c9ae039 May 10, 2022 09:48
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

[jans-config-api-parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
9.4% 9.4% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

[SCIM API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pujavs pujavs requested review from devrimyatar and yuriyz May 10, 2022 09:59
@yuriyz yuriyz merged commit 88c3fff into main May 10, 2022
@yuriyz yuriyz deleted the jans-config-api-1224 branch May 10, 2022 10:20
@pujavs pujavs mentioned this pull request May 12, 2022
Closed
@mo-auto mo-auto mentioned this pull request May 18, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR comp-jans-config-api Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pujavs @yuriyz @devrimyatar @mo-auto