Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate password file in favor of secrets #150

Closed
wants to merge 18 commits into from
Closed

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Dec 8, 2021

The changeset deprecate password files (sql_password, couchbase_password, couchbase_superuser_password) in favor of value from secrets.
For existing deployments, the password from any of password files mentioned previously is saved into secrets. Subsequent deployment may remove the password files safely.
For fresh deployments, there are additional scopes and attributes that can be used to specify password for SQL and Couchbase databases.

@iromli iromli requested a review from moabu as a code owner December 8, 2021 20:12
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #150 (a1b854f) into master (2d5d61b) will decrease coverage by 0.28%.
The diff coverage is 90.00%.

❗ Current head a1b854f differs from pull request most recent head a2d3a16. Consider uploading reports for the commit a2d3a16 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   68.80%   68.51%   -0.29%     
==========================================
  Files          29       29              
  Lines        1683     1674       -9     
==========================================
- Hits         1158     1147      -11     
- Misses        525      527       +2     
Flag Coverage Δ
unittests 68.51% <90.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jans-pycloudlib/jans/pycloudlib/utils.py 80.26% <ø> (-2.40%) ⬇️
jans-pycloudlib/jans/pycloudlib/persistence/sql.py 50.67% <87.50%> (+0.67%) ⬆️
...ycloudlib/jans/pycloudlib/persistence/couchbase.py 84.27% <91.66%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4cc37...a2d3a16. Read the comment docs.

@iromli iromli closed this Dec 9, 2021
moabu pushed a commit that referenced this pull request Jan 13, 2022
feat: enable/disable admin-ui frontend plugins (ref: #150)
moabu pushed a commit that referenced this pull request Jan 13, 2022
feat: enable/disable admin-ui frontend plugins (ref: #150)
This was referenced Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants