feat: add newly redesigned jans-client-api #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview: - jans-client-api is now running behind jetty server - add new env var CN_CLIENT_API_CN_CERT to gradually replace CN_CLIENT_API_APPLICATION_CERT_CN - CN_CLIENT_API_APPLICATION_CERT_CN and CN_CLIENT_API_ADMIN_CERT_CN are deprecated
mo-auto
added
area-CI
|
[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!
|
|
@moabu PR is ready for review. |
|
[jans-cli] Kudos, SonarCloud Quality Gate passed!
|
|
[jans-client-api] Kudos, SonarCloud Quality Gate passed!
|
moabu
requested changes
Jun 13, 2022
Comment on lines
54
to
63
| - variable: config.configmap.cnClientApiApplicationCertCn | ||
| default: "client-api" | ||
| description: "Client API application keystore name" | ||
| description: "Client API application keystore name (deprecated in favor of config.configmap.cnClientApiCertCn)" | ||
| type: string | ||
| label: Client API application keystore name | ||
| - variable: config.configmap.cnClientApiAdminCertCn | ||
| default: "client-api" | ||
| description: "Client API admin keystore name" | ||
| description: "Client API admin keystore name (deprecated)" | ||
| type: string | ||
| label: Client API admin keystore name |
There was a problem hiding this comment.
This section can be removed. A deprecated note is not needed since this service was never in a working state.
Comment on lines
137
to
140
| # deprecated in favor of CN_CLIENT_API_CERT_CN | ||
| CN_CLIENT_API_APPLICATION_CERT_CN: {{ .Values.configmap.cnClientApiApplicationCertCn | quote }} | ||
| # deprecated | ||
| CN_CLIENT_API_ADMIN_CERT_CN: {{ .Values.configmap.cnClientApiAdminCertCn | quote }} |
There was a problem hiding this comment.
This section can be removed. A deprecated note is not needed since this service was never in a working state.
charts/janssen/values.schema.json
Outdated
Comment on lines
81
to
90
| "cnClientApiAdminCertCn": { | ||
| "description": "Client-api OAuth client admin certificate common name. This should be left to the default value client-api", | ||
| "description": "Client-api OAuth client admin certificate common name. This should be left to the default value client-api (deprecated)", | ||
| "type": "string", | ||
| "pattern": "^[a-z-]+$" | ||
| }, | ||
| "cnClientApiApplicationCertCn": { | ||
| "description": "Client-api OAuth client application certificate common name. This should be left to the default value client-api", | ||
| "description": "Client-api OAuth client application certificate common name. This should be left to the default value client-api (deprecated in favor of cnClientApiCertCn)", | ||
| "type": "string", | ||
| "pattern": "^[a-z-]+$" | ||
| }, |
docker-jans-client-api/README.md
Outdated
Comment on lines
63
to
64
| - `CN_CLIENT_API_APPLICATION_CERT_CN`: CommonName used in application certificate subject. This environment variable is **DEPRECATED** in favor of `CN_CLIENT_API_CERT_CN`. | ||
| - `CN_CLIENT_API_ADMIN_CERT_CN`: CommonName used in admin certificate subject. This environment variable is **DEPRECATED** and no longer used. |
Comment on lines
+95
to
+103
| "client_api_log_level": "INFO", | ||
| "persistence_log_target": "FILE", | ||
| "persistence_log_level": "INFO", | ||
| "persistence_duration_log_target": "FILE", | ||
| "persistence_duration_log_level": "INFO", | ||
| "ldap_stats_log_target": "FILE", | ||
| "ldap_stats_log_level": "INFO", | ||
| "script_log_target": "FILE", | ||
| "script_log_level": "INFO" |
moabu
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changeset adds/updates several areas listed below:
jans-client-apiis updatedjans-client-apiCN_CLIENT_API_CERT_CNto gradually replace deprecatedCN_CLIENT_API_APPLICATION_CERT_CNandCN_CLIENT_API_ADMIN_CERT_CNNote: the env var
CN_CLIENT_API_APPLICATION_CERT_CNis used as backward-compat. An ideal upgrade involves removing the env var and useCN_CLIENT_API_CERT_CNinstead.