Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: proper activation of config-api plugins #1626

Closed
iromli opened this issue Jun 28, 2022 · 0 comments · Fixed by #1627
Closed

feat: proper activation of config-api plugins #1626

iromli opened this issue Jun 28, 2022 · 0 comments · Fixed by #1627
Assignees
@iromli @moabu
Labels
comp-docker-jans-config-api kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Milestone
1.0.1

Comments

@iromli
Copy link
Contributor

iromli commented Jun 28, 2022

Is your feature request related to a problem? Please describe.

In janssenproject/config-api image, plugins activation is determined by CN_CONFIG_API_PLUGINS environment variable. For example, to activate admin-ui plugin, set the env CN_CONFIG_API_PLUGINS=admin-ui. However, this env overlaps with shell function in entrypoint.sh (where the function will copy all available plugins even they are not defined in CN_CONFIG_API_PLUGINS env).

Describe the solution you'd like

The plugins activation (including copying plugin assets, configuration, etc) should be determined via CN_CONFIG_API_PLUGINS env.

Additional context

Available plugins:

  • admin-ui
  • scim
  • fido2 (TBA)
  • user-mgt (TBA)
@iromli iromli added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-docker-jans-config-api labels Jun 28, 2022
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jun 28, 2022
@iromli iromli mentioned this issue Jun 28, 2022
Merged
3 tasks
@iromli iromli linked a pull request Jun 28, 2022 that will close this issue
feat: proper plugin activation of config-api container #1627
Merged
3 tasks
@moabu moabu added this to the 1.0.1 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iromli iromli

@moabu moabu

Labels
comp-docker-jans-config-api kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

feat: proper plugin activation of config-api container JanssenProject/jans
3 participants
@iromli @moabu @mo-auto