Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login.xhtml): add google client js #1666

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix(login.xhtml): add google client js #1666

merged 1 commit into from
Jul 13, 2022

Conversation

kdhttps
Copy link
Contributor

@kdhttps kdhttps commented Jul 4, 2022

Prepare

Description

Target issue

#1663

Implementation Details

Update .../google/login.xhtml to add latest Google API JS

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Documentation updated here

@kdhttps kdhttps requested a review from maduvena July 4, 2022 13:39
@kdhttps kdhttps requested review from yurem and yuriyz as code owners July 4, 2022 13:39
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jul 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

[Jans authentication server parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@moabu moabu merged commit daf9849 into main Jul 13, 2022
@moabu moabu deleted the jans-auth-server-google-fix branch July 13, 2022 12:26
@mo-auto mo-auto mentioned this pull request Aug 30, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maduvena maduvena maduvena approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

@yuriyz yuriyz Awaiting requested review from yuriyz yuriyz is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kdhttps @maduvena @moabu @mo-auto