Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-client-api): jans-config-api dependency removed and wrong test dependencies solved #1737

Merged
merged 1 commit into from
Jul 8, 2022
Merged

fix(jans-client-api): jans-config-api dependency removed and wrong test dependencies solved #1737

merged 1 commit into from
Jul 8, 2022

Conversation

jmunozherbas
Copy link
Contributor

Prepare

Description

Target issue

#1723

Implementation Details

Dependency removed, and test dependencies problems fixed.

Test and Document the changes

  • [ X] Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)
    README was updated (command to run test with url).

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-client-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jul 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yuriyz yuriyz marked this pull request as ready for review July 8, 2022 13:50
@yuriyz yuriyz merged commit 97dbe9c into main Jul 8, 2022
@yuriyz yuriyz deleted the fix-jans-client-api-cross-dependency-jans-config-api branch July 8, 2022 13:51
@yuriyz
Copy link
Contributor

yuriyz commented Jul 8, 2022

I moved it out of draft and merged since it resolves jans-config-api cycle dependency problem.
@jmunozherbas if you planned some other changes here please open separate PR.

@mo-auto mo-auto mentioned this pull request Aug 30, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@duttarnab duttarnab Awaiting requested review from duttarnab

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-client-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmunozherbas @yuriyz @mo-auto