FEAT / Added config to disable attempt to update before insert in cache #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[jans-core] Kudos, SonarCloud Quality Gate passed! |
yuriyz
reviewed
Jul 13, 2022
| @@ -82,6 +82,9 @@ public void create() { | |||
| // CouchbaseEntryManagerFactory.PERSISTENCE_TYPE | |||
| skipRemoveBeforePut = "couchbase".equals(persistenceType); | |||
| attemptUpdateBeforeInsert = "sql".equals(persistenceType); | |||
| if (cacheConfiguration.getNativePersistenceConfiguration().isDisableAttemptUpdateBeforeInsert()) { | |||
There was a problem hiding this comment.
Actually, I talked with him before doing these changes, but let's see Yure's feedback in case I misunderstood something.
There was a problem hiding this comment.
yes, for #207 we already updated code. But this new property will allow us to check at runtime which approach is better for specific DB MySQL/Postgress/etc
There was a problem hiding this comment.
Agreed, yes, it can be useful.
yurem
approved these changes
Jul 15, 2022
| @@ -82,6 +82,9 @@ public void create() { | |||
| // CouchbaseEntryManagerFactory.PERSISTENCE_TYPE | |||
| skipRemoveBeforePut = "couchbase".equals(persistenceType); | |||
| attemptUpdateBeforeInsert = "sql".equals(persistenceType); | |||
| if (cacheConfiguration.getNativePersistenceConfiguration().isDisableAttemptUpdateBeforeInsert()) { | |||
There was a problem hiding this comment.
yes, for #207 we already updated code. But this new property will allow us to check at runtime which approach is better for specific DB MySQL/Postgress/etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added config to disable attempt to update before insert in cache.
Target issue
#207