Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardize how to add custom client claims (i.e. extend client schema) #2295

Closed
nynymike opened this issue Sep 2, 2022 · 3 comments
Closed
Assignees
Labels
comp-jans-auth-server Component affected by issue or PR enhancement
Milestone

Comments

@nynymike
Copy link
Contributor

nynymike commented Sep 2, 2022

Just like there is a process for extending the schema of a person, organizations may need to add custom claims to the client object. Just a single example, let's say an organization has a business division code for distinct sets of clients, and wants to search to get a list of clients via the config api?

@yuriyz
Copy link
Contributor

yuriyz commented Sep 5, 2022

We have the way to extend Client attributes similar to User/Person mechanism. Following configuration allows custom attributes for client.

  • dynamicRegistrationCustomObjectClass - specifies custom OC for client.
  • dynamicRegistrationCustomAttributes - specifies custom attributes
...
 "dynamicRegistrationCustomObjectClass": "MyDynamicRegistrationCustomObject", 
 "dynamicRegistrationCustomAttributes": [
    "jansTrustedClnt",
    "myAttr1"
  ],
...

References (it's for gluu but same works in jans):

@moabu moabu changed the title Feat: Standardize how to add custom client claims (i.e. extend client schema) feat: standardize how to add custom client claims (i.e. extend client schema) Sep 5, 2022
@moabu moabu assigned yuriyz and unassigned moabu Sep 5, 2022
@yuriyz yuriyz added the comp-jans-auth-server Component affected by issue or PR label Sep 6, 2022
@yuriyz yuriyz added this to the 1.0.3 milestone Sep 7, 2022
@yuriyz
Copy link
Contributor

yuriyz commented Sep 7, 2022

@nynymike do we need to add something else or above is enough?

@moabu moabu modified the milestones: 1.0.3, 1.0.4 Nov 3, 2022
@yuriyz
Copy link
Contributor

yuriyz commented Nov 9, 2022

Client schema is extended via dynamicRegistrationCustomObjectClass and dynamicRegistrationCustomAttributes as described in comment above. @nynymike closing this ticket, please re-open if we need to change or improve our current approach.

@yuriyz yuriyz closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR enhancement
Projects
None yet
Development

No branches or pull requests

3 participants