Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-config-api): organization attributes not updated #2756

Closed
moabu opened this issue Oct 28, 2022 · 7 comments
Closed

fix(jans-config-api): organization attributes not updated #2756

moabu opened this issue Oct 28, 2022 · 7 comments
Assignees
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@moabu
Copy link
Member

moabu commented Oct 28, 2022

When updating the organization, the organization title, as well as the DN/BaseDN are not updated.

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Oct 28, 2022
@pujavs
Copy link
Contributor

pujavs commented Nov 1, 2022

@moabu, dn and baseDn are internally generated and can be updated to only applicable schema values to avoid schema class violation and the config-api endpoints conforms to it. Same is applicable to dn and baseDn update for any schema object.

Video:
SMTP_dn_baseDN_Issue_2756.zip

Screenshots:
image
image
image
image

@moabu moabu added this to the 1.0.4 milestone Nov 3, 2022
@moabu
Copy link
Member Author

moabu commented Nov 4, 2022

OK, understood about the Dn/BaseDn, however, I'm not always getting an error from the API when using an incorrect value. For example following request returns a 200 OK response:

[
	{"op":"add","path":"/dn","value":"ou=groups,o=jans"},
	{"op":"add","path":"/baseDn","value":"o=janssen"}
]

If the API doesn't return an error, it's hard to handle it properly on the provider side.

Also what about the OrganizationTitle? Should I be able to change that?

@pujavs
Copy link
Contributor

pujavs commented Nov 9, 2022

on verifying the code found that we have organizationTitle only getter without any setter or corresponding attribute in model class.
@yuriyz request your advice.
https://github.com/JanssenProject/jans/blob/main/jans-auth-server/persistence-model/src/main/java/io/jans/as/persistence/model/GluuOrganization.java#L92
image

@yuriyz
Copy link
Contributor

yuriyz commented Nov 9, 2022

@pujavs removed this method in https://github.com/JanssenProject/jans/pull/2948/files

We don't need it, I removed it. There is already getter/setter for title.

@pujavs
Copy link
Contributor

pujavs commented Nov 9, 2022

thankyou @yuriyz
cc @moabu

@moabu
Copy link
Member Author

moabu commented Nov 9, 2022

Ok I'll confirm and close the ticket if everything goes as expected . Thanks @yuriyz and @pujavs

@moabu
Copy link
Member Author

moabu commented Nov 30, 2022

Confirmed.

@moabu moabu closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants