Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): avoid compilation problem when version is flipped in test code #3148 #3210

Merged
merged 1 commit into from
Dec 5, 2022
Merged

feat(jans-auth-server): avoid compilation problem when version is flipped in test code #3148 #3210

merged 1 commit into from
Dec 5, 2022

Conversation

yuriyz
Copy link
Contributor

@yuriyz yuriyz commented Dec 5, 2022

Prepare

Description

feat(jans-auth-server): avoid compilation problem when version is flipped in test code #3148

Target issue

closes #3148

Implementation Details

Added new test-model module for reusing test code.

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@yuriyz yuriyz requested a review from yurem as a code owner December 5, 2022 11:48
@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Dec 5, 2022
@yuriyz yuriyz merged commit 4d61c7b into main Dec 5, 2022
@yuriyz yuriyz deleted the jans-auth-server-3148 branch December 5, 2022 11:49
@yuriyz yuriyz self-assigned this Dec 5, 2022
@mo-auto3 mo-auto3 mentioned this pull request Jan 9, 2023
Merged
@mo-auto mo-auto mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-auth-server): during new release when version flipped it's hard to build jans-auth tests
2 participants
@yuriyz @mo-auto