Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename role_based_client as tui_client #3657

Merged
merged 3 commits into from
Jan 23, 2023
Merged

fix: rename role_based_client as tui_client #3657

merged 3 commits into from
Jan 23, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Jan 20, 2023

Prepare

Description

Target issue

closes #3655

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@sonarqubecloud
Copy link

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-persistence-loader comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 20, 2023
moabu
moabu previously approved these changes Jan 20, 2023
View reviewed changes
devrimyatar
devrimyatar reviewed Jan 21, 2023
View reviewed changes
Copy link
Contributor

@devrimyatar devrimyatar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In file install.md

Please change
cat /opt/jans/jans-setup/setup.properties.last | grep role
to
cat /opt/jans/jans-setup/setup.properties.last | grep tui_client
Note: There are two such lines

@iromli
Copy link
Contributor Author

iromli commented Jan 21, 2023

In file install.md

Please change cat /opt/jans/jans-setup/setup.properties.last | grep role to cat /opt/jans/jans-setup/setup.properties.last | grep tui_client Note: There are two such lines

@devrimyatar Done

@moabu moabu merged commit c393cb2 into main Jan 23, 2023
@moabu moabu deleted the cn-tui-client branch January 23, 2023 20:18
pujavs pushed a commit that referenced this pull request Jan 25, 2023
@iromli @pujavs
fix: rename role_based_client as tui_client (#3657)
e6b432b
@mo-auto mo-auto mentioned this pull request Feb 22, 2023
Merged
@mo-auto2 mo-auto2 mentioned this pull request Feb 22, 2023
Merged
This was referenced Feb 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devrimyatar devrimyatar devrimyatar approved these changes

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-docker-jans-persistence-loader comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans): change role_based_client to tui_client
4 participants
@iromli @devrimyatar @moabu @mo-auto