Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set public subject identifier per client #368

Closed
martynaslawinska opened this issue Feb 12, 2021 · 3 comments
Closed

Set public subject identifier per client #368

martynaslawinska opened this issue Feb 12, 2021 · 3 comments
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality triaged Issue or PR is fully triaged

Comments

@martynaslawinska
Copy link

It's possible that one application would want email as the public identifier for subject, while another might want username. We should enable the public subject identifier to be set on a per client basis.
@ghost ghost assigned yuriyz Dec 27, 2021
@ghost ghost assigned qbert2k and unassigned yuriyz Jan 10, 2022
@ossdhaval ossdhaval transferred this issue from another repository Jan 13, 2022
@ossdhaval ossdhaval added comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review. labels Jan 13, 2022
@qbert2k qbert2k added triaged Issue or PR is fully triaged area-documentation Documentation needs to change as part of issue or PR and removed needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review. labels Feb 10, 2022
qbert2k referenced this issue Feb 10, 2022
@qbert2k
feat(jans-auth-server): set public subject identifier per client
f00a322
@qbert2k
Copy link
Contributor

qbert2k commented Feb 10, 2022

  1. In the configuration, set publicSubjectIdentifierPerClientEnabled to true.
  2. Configure the supported attributes.

image

@qbert2k qbert2k mentioned this issue Feb 10, 2022
Merged
@yuriyz
Copy link
Contributor

yuriyz commented Feb 14, 2022

@qbert2k we got test failures after PR merge (#800)
Would you please check?

image

https://jenkins.jans.io/jenkins/job/jans-auth-server/5512/

@yuriyz
Copy link
Contributor

yuriyz commented Feb 17, 2022 •
edited
Loading

Restored Javier's commits which was removed during jans-linux-setup refactoring by Mustafa. It fixed tests.
#835

Closing this ticket as solved.
@qbert2k Please re-open if needed.

@yuriyz yuriyz closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality triaged Issue or PR is fully triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ossdhaval @yuriyz @qbert2k @martynaslawinska