Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-config-api): runtime exceptions in config-api at startup #3725

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

maduvena
Copy link
Contributor

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jan 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pujavs
pujavs previously approved these changes Jan 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

[Jans authentication server parent] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

}

@Inject
private UserService userService;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it works well without @Named("userFido2Srv") ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear because we use the same io.jans.as.common.service.common.UserService in old RegistrationPersistenceService and there

@yurem yurem merged commit 8748cc3 into main Jan 31, 2023
@yurem yurem deleted the common_abstract branch January 31, 2023 09:05
@maduvena maduvena restored the common_abstract branch January 31, 2023 09:23
@moabu moabu deleted the common_abstract branch June 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants