Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: use key_ops=ssa to generate JWT from SSA #3806

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Feature: use key_ops=ssa to generate JWT from SSA #3806

merged 1 commit into from
Feb 8, 2023

Conversation

Milton-Ch
Copy link
Contributor

Prepare

Description

  • The generateJwt method has been modified to filter by key_ops=ssa to obtain the keyId.
  • A new invalid_signature exception has been added to check that the algorithm configured in ssaSigningAlg exists in the webKeysConfiguration list.

closes #3746

@mo-auto mo-auto added comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR labels Feb 8, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

[Jans authentication server parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Milton-Ch Milton-Ch marked this pull request as ready for review February 8, 2023 05:38
@yuriyz yuriyz merged commit 2603bbb into main Feb 8, 2023
@yuriyz yuriyz deleted the feat/use-keyops-ssa branch February 8, 2023 07:36
This was referenced Feb 22, 2023
Merged
Merged
@mo-auto mo-auto mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@devrimyatar devrimyatar Awaiting requested review from devrimyatar devrimyatar is a code owner

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-auth-server): /ssa endpoint must use key_ops=ssa keys
3 participants
@Milton-Ch @yuriyz @mo-auto