Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug in setting acr_values in clients #3888

Closed
moabu opened this issue Feb 20, 2023 · 3 comments
Closed

fix: bug in setting acr_values in clients #3888

moabu opened this issue Feb 20, 2023 · 3 comments
Assignees
@devrimyatar
Labels
kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.12

Comments

@moabu
Copy link
Member

moabu commented Feb 20, 2023 •
edited
Loading

Describe the bug

  1. If a script is set in the client as a default acr to be used it doesn't work. It will assign it correctly in the url i.e &acr_values=inum..... but it won't work showing a white screen
  2. the default server acr somehow was empty upon a fresh setup.
@moabu moabu self-assigned this Feb 20, 2023
@mo-auto mo-auto added the kind-bug Issue or PR is a bug in existing functionality label Feb 20, 2023
@jgomer2001
Copy link
Contributor

just in case - you pass script display name, not inum

@moabu moabu added this to the 1.0.9 milestone Mar 1, 2023
@moabu moabu modified the milestones: 1.0.9, 1.0.10 Mar 9, 2023
@yuriyz yuriyz assigned devrimyatar and unassigned moabu Mar 15, 2023
@yuriyz
Copy link
Contributor

yuriyz commented Mar 15, 2023

re: 1, @jgomer2001 is right, we must use name of the script, not inum.

re: 2, reassigned to @devrimyatar to check installation.

@devrimyatar devrimyatar mentioned this issue Mar 15, 2023
Closed
@moabu moabu modified the milestones: 1.0.10, 1.0.11 Mar 16, 2023
@moabu moabu modified the milestones: 1.0.11, 1.0.12 Apr 5, 2023
@devrimyatar
Copy link
Contributor

Fixed in PR #4356

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

Labels
kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.12
Development

No branches or pull requests
5 participants
@yuriyz @jgomer2001 @devrimyatar @moabu @mo-auto