Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-fido2):handling exception fido2 get endpoints by invalid params #4139

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix(jans-fido2):handling exception fido2 get endpoints by invalid params #4139

merged 1 commit into from
Mar 14, 2023

Conversation

jmunozherbas
Copy link
Contributor

Prepare

Description

Issue was caused due to direct exception throwing

Target issue

#3902

closes #3902

Implementation Details

ErrorResponse was implemented similar to jans-auth-server using a WebApplicationException.
The error is showed in a detailed json.

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Mar 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

[Fido2 API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yurem yurem merged commit a50d2af into main Mar 14, 2023
@yurem yurem deleted the fix-jans-fido2-handling-get-endpoints-invalid-params branch March 14, 2023 11:33
@mo-auto3 mo-auto3 mentioned this pull request Mar 16, 2023
Merged
@mo-auto mo-auto mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurem yurem yurem approved these changes

@maduvena maduvena Awaiting requested review from maduvena

Assignees
No one assigned
Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-fido2): Exception handling for endpoints
3 participants
@jmunozherbas @yurem @mo-auto