Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): smtp password decryption and encryption logic #4161

Merged
merged 13 commits into from
Mar 15, 2023
Merged

fix(config-api): smtp password decryption and encryption logic #4161

merged 13 commits into from
Mar 15, 2023

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Mar 15, 2023

Prepare

Description

SMTP logic enhancement for password encryption and decryption

  • config-api to always encrypt and save the pwd- POST/PUT
  • config-api to always return the pwd in clear text - GET/PUT/POST response
  • client should always send pwd in clear text

Target issue

closes # 4127

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs
fix(config-api): customObjectClass changes
93b5bec
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
d8908ec 
…ns-config-fix
@pujavs
fix(config-api): user custom attribute changes and agama param changes
5315017
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
3b05bbb 
…ns-config-fix
@pujavs
fix(config-api): user custom attribute changes and agama param changes
2e3e141
@pujavs
fix(config-api): user custom attribute changes and agama param changes
c5e458b
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
a1e9b4b 
…ns-config-fix
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
e195ebc 
…ns-config-fix
@pujavs
feat(config-api): agama deployment path param change and client autho…
bad1ad6 
…rization
@pujavs
feat(config-api): agama deployment path param change and client autho…
c5f467e 
…rization
@pujavs
feat(config-api): agama deployment path param change and client autho…
48de61d 
…rization
@pujavs
Merge branch 'main' of https://github.com/JanssenProject/jans into ja…
ba7fff9 
…ns-config-fix
@pujavs
fix(config-api): smtp password decryption and encryption logic
35cc5dd
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Mar 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yuriyz yuriyz merged commit 4aefb0d into main Mar 15, 2023
@yuriyz yuriyz deleted the jans-config-fix branch March 15, 2023 18:50
@mo-auto3 mo-auto3 mentioned this pull request Mar 16, 2023
Merged
@mo-auto mo-auto mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pujavs @yuriyz @mo-auto