Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-jans-loadtesting-jmeter): rename incorrect reference to OCI image #4908

Merged
merged 2 commits into from
May 10, 2023
Merged

fix(docker-jans-loadtesting-jmeter): rename incorrect reference to OCI image #4908

merged 2 commits into from
May 10, 2023

Conversation

iromli
Copy link
Contributor

@iromli iromli commented May 9, 2023

Prepare

Description

Target issue

closes #4906

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@iromli iromli requested a review from moabu May 9, 2023 18:34
@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality labels May 9, 2023
moabu
moabu requested changes May 9, 2023
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update benchmark document in docs with changes .

@moabu moabu merged commit 7db2c11 into main May 10, 2023
@moabu moabu deleted the cn-loadtesting-jmeter branch May 10, 2023 07:04
@mo-auto mo-auto mentioned this pull request May 10, 2023
Merged
@mo-auto3 mo-auto3 mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(docker-jans-loadtesting-jmeter): incorrect reference to OCI image
3 participants
@iromli @moabu @mo-auto