Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: after monorepo related changes PR does not build the impacted projects #841

Closed
pujavs opened this issue Feb 17, 2022 · 3 comments
Closed

BUG: after monorepo related changes PR does not build the impacted projects #841

pujavs opened this issue Feb 17, 2022 · 3 comments
Assignees
@ossdhaval
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality triaged Issue or PR is fully triaged
Milestone
1.0.21

Comments

@pujavs
Copy link
Contributor

pujavs commented Feb 17, 2022

If a PR has changes to multiple projects then the build should be triggered for all, however the build is triggered only for one project causing the maven run to fail as dependent changes not avialable.

Example: #840
In same PR there are changes in jans-core as well as jans-config-api
jans-config-api changes are dependent on jans-core and while sonar build it is not able to find the jans-core changes because it’s not there in the maven repo yet and fails.
@moabu moabu assigned ossdhaval and unassigned moabu Feb 21, 2022
@ossdhaval ossdhaval added area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality triaged Issue or PR is fully triaged labels Feb 23, 2022
@moabu moabu added this to the 1.0.1 milestone Jun 15, 2022
@moabu moabu modified the milestones: 1.0.1, 1.0.2 Jul 8, 2022
@moabu moabu modified the milestones: 1.0.2, 1.0.3 Aug 30, 2022
@moabu moabu modified the milestones: 1.0.3, 1.0.4 Nov 3, 2022
@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
@moabu moabu modified the milestones: 1.0.5, 1.0.6 Dec 1, 2022
@moabu moabu modified the milestones: 1.0.6, 1.0.7 Jan 9, 2023
@moabu moabu modified the milestones: 1.0.7, 1.0.8, 1.0.9 Mar 1, 2023
@moabu moabu modified the milestones: 1.0.9, 1.0.10 Mar 9, 2023
@moabu moabu modified the milestones: 1.0.10, 1.0.11 Mar 16, 2023
@moabu moabu modified the milestones: 1.0.11, 1.0.12 Apr 5, 2023
@moabu moabu removed this from the 1.0.12 milestone Apr 18, 2023
@moabu moabu added this to the 1.0.13 milestone Apr 18, 2023
@moabu moabu modified the milestones: 1.0.13, 1.0.14 May 10, 2023
@moabu moabu modified the milestones: 1.0.14, 1.0.15 Jun 20, 2023
@moabu moabu modified the milestones: 1.0.15, 1.0.16 Jul 12, 2023
@moabu moabu modified the milestones: 1.0.16, 1.0.17 Aug 2, 2023
@moabu moabu modified the milestones: 1.0.17, 1.0.18 Sep 18, 2023
@moabu moabu modified the milestones: 1.0.18, 1.0.21 Nov 22, 2023
@ossdhaval
Copy link
Contributor

Hi @pujavs

This bug was reported long back. Have you seen this behavior more recently? Is there a way to confirm?

@pujavs
Copy link
Contributor Author

pujavs commented Dec 7, 2023

@ossdhaval
I have not noticed this lately. To test this we have to change more than one module and then raise a PR.

@ossdhaval
Copy link
Contributor

@pujavs

Thank you for your comments. For now, I am closing this. If you see a reoccurrence, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ossdhaval ossdhaval

Labels
area-CI Issue or changes required in automatic builds or CI infrastructure kind-bug Issue or PR is a bug in existing functionality triaged Issue or PR is fully triaged
Projects
None yet
Milestone
1.0.21
Development

No branches or pull requests
3 participants
@ossdhaval @pujavs @moabu