Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar module custom icons #268

Open
paiyayay opened this issue Sep 17, 2024 · 12 comments
Open

Bar module custom icons #268

paiyayay opened this issue Sep 17, 2024 · 12 comments
Labels
enhancement New feature or request

Comments

@paiyayay
Copy link

Is your feature request related to a problem? Please describe.
It would be cool to configure icons of the battery, bluetooth, wifi, sound to our liking. Right now only date (clock) icon can be set.

Describe the solution you'd like
Additional menu items to set icons. Like probably battery needs 5ish icons, sound 3 icons. The waybar way.

Describe alternatives you've considered
Straight forward.

Additional context
None

@paiyayay paiyayay changed the title Custom bar module icons Bar module custom icons Sep 17, 2024
@Jas-SinghFSU Jas-SinghFSU added the enhancement New feature or request label Sep 19, 2024
@rubiin
Copy link
Contributor

rubiin commented Oct 17, 2024

Also @Jas-SinghFSU is there a way to define a module yourself. User custom module

@rubiin
Copy link
Contributor

rubiin commented Oct 20, 2024

Maybe we can break this into multiple features:

  • bluetooth
  • notifications
  • battery
  • wifi
  • power
  • media

@paiyayay
Copy link
Author

Also @Jas-SinghFSU is there a way to define a module yourself. User custom module

there are custom modules but this feature should use the ones that are stock. and give more customizablity.

@rubiin
Copy link
Contributor

rubiin commented Oct 21, 2024

image

image

Regarding icons, we should allow a field to specify comma separate values similar to waybar as on the above screenshot while preserving the current as default

@paiyayay
Copy link
Author

this will make it a true waybar replacement

@rubiin
Copy link
Contributor

rubiin commented Oct 26, 2024

@Jas-SinghFSU what do you think ? should we use object or array like the above for things like volumes, bluetooth?

@Jas-SinghFSU
Copy link
Owner

How does Waybar determine which icon to view? For instance, I see 9 in the format-icons array but which value determines when to display it?

@paiyayay
Copy link
Author

i think most reasonable function is like this: divide 100 by list length and give the corresponding icon by that value. for example 100 divided by 10 is 10, this means if the battery percentage is 35 we get the 4th element.

step = 100 / icon_array.length

icon_array[
battery_percentage // step
]

// is no remainder division operator

@rubiin
Copy link
Contributor

rubiin commented Oct 26, 2024

for volume it would work. But for bluetooth and other modules that only have two states (on and off), it would create a confusion on UX

@paiyayay
Copy link
Author

we can leave a note under the icon list input field. says first element = off, second element = on or something.

then I guess take the boolean value of the bluetooth for example get icon_list[bluetoothIsOn]

@rubiin
Copy link
Contributor

rubiin commented Oct 26, 2024

I guess we can do something like this with instruction on label

	["icon1","icon2","icon2","icon3","icon4"] with label as [20%, 30%, 50%, 80%, 100%]
	
		["icon1","icon2"]   with label [on, off]

@Jas-SinghFSU
Copy link
Owner

[
  ["icon1", "on"],
  ["icon2", "off"],
]

I think this would make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants