JBLineChartView doesn't resize its subviews

[nicolasgoutaland]

Hi,

when resized, JBLineChartView doesn't resizes its subviews (such as JBLineChartDotsView and JBLineChartLinesView).

A fix will be to add

    self.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;

in their constructors.
I think once resized, JBLineChartView should redraw its content, perhaps by adding a KVO on its frame ?

Regards,

[terryworona]

I've been getting around this by calling reloadData after a frame change.

See https://github.com/Jawbone/anscombe-quartet-ios for an example.

I could simply call reloadData after JBChartView's frame is set:

- (void)setFrame:(CGRect)frame
{
    [super setFrame:frame];
    [self reloadData];
}

Thoughts?

[terryworona]

Fixed in version 2.8.9 -- go ahead and give it a try.

[nicolasgoutaland]

Seems good, but I don't think that reloading data when frame is updated is a good practice. It could be very time consuming, no ?

[terryworona]

reload data is fairly quick - it's just requesting data - no drawing taking place.

The UI loop will re-draw all the subviews regardless if reloadData is called or not; meaning the largest toll on performance is going to occur regardless.

[terryworona]

I rolled this fix back as our own personal projects seem to call setFrame quite often during touch events.

Rolled back via commit: efd8f97

For now, devs should just know to call reloadData after each frame change. I've added this to the documentation.