Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reloadData is not reducing height of other bars #7

Closed
l4u opened this issue Jan 2, 2014 · 3 comments
Closed

reloadData is not reducing height of other bars #7

l4u opened this issue Jan 2, 2014 · 3 comments

Comments

@l4u
Copy link
Contributor

l4u commented Jan 2, 2014

When a bar's height is taller than the previous maximum, the height of other bars should be reduced (normalized).
@wtsnz
Copy link

wtsnz commented Jan 2, 2014

I noticed this issue while playing around with it too. I've fixed it in my fork, but the issue was that self.cachedMaxHeight was not recalculated when [self maxHeight] was called in reloadData.

Just set self.cachedMaxHeight to kJBBarChartViewUndefinedMaxHeight in the reloadData function at the end of the createDataDictionaries block. This then forces the barchartview to recalculate the height.

@wtsnz
Copy link

wtsnz commented Jan 2, 2014

Started writing response before I saw you referenced your fix, duh!

@l4u
Copy link
Contributor Author

l4u commented Jan 2, 2014

Yeah, thanks for your help anyway @wtsnz.

terryworona added a commit that referenced this issue Jan 2, 2014
@terryworona
Merge pull request #8 from l4u/cache
6f185f9 
Reset cached max height on data reload Fixes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l4u @wtsnz