Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The popup is disappeared after 1 approval #29

Closed
sergeyk93 opened this issue Sep 1, 2015 · 12 comments
Closed

The popup is disappeared after 1 approval #29

sergeyk93 opened this issue Sep 1, 2015 · 12 comments
Labels

Comments

@sergeyk93
Copy link

Hi,

First of all thank you for the plugin, it's great. I have one issue with it though. It works fine in my site, I use it only for the home page, however, after pressing enter once the popup won't show up again unless i clear my cookies. I thought if I'd enter 0 in the cookie life field it would create a cookie just for the browsing session, however in that case it doesn't create a cookie at all and the pop up just pops after each click. I saw in your video that it's possible that the pop up will show in every time you enter a page, that's what I'd like.
I'm using the latest version: 3.6.4.

Thank you very much!

@JayWood
Copy link
Owner

JayWood commented Sep 1, 2015

@sergeyk93 thanks for the reminder, I seen this bug as well, will be fixed in a day or so, sorry for the inconvenience.

@JayWood JayWood added the bug label Sep 1, 2015
@sergeyk93
Copy link
Author

I'll be waiting for an update, thank you very much for the response and the plugin :)

@JayWood JayWood closed this as completed in 668687c Sep 6, 2015
@sergeyk93
Copy link
Author

Hi,

I've updated to the newest version, yet the bug still occurs. When I click enter the popup pops again.

@JayWood
Copy link
Owner

JayWood commented Sep 6, 2015

@sergeyk93 make sure you cleared your browser cache, as well as your sites cache, if you cache pages. Also, please provide a screenshot of your settings page if you wouldn't mind.

@JayWood JayWood reopened this Sep 6, 2015
@sergeyk93
Copy link
Author

I've tried clearing the cache before I posted this message.
And sure thing, here's a photo:
untitled

@JayWood
Copy link
Owner

JayWood commented Sep 6, 2015

@sergeyk93 I'm unable to replicate the issue with the same settings ( aside from the content in the popup of course ) This leads me to believe it may be a browser issue on the client side. If you can provide me with a link to your site maybe I can debug a little bit more.

Additionally, if you're hesitant to do so, as most are on a public forum, feel free to send it to me via my contact page on plugish.com

See attached GIF
csv3_cookie

@sergeyk93
Copy link
Author

The enter link should be '#'?
Because the enter link in my is the URL to my site, perhaps that's the problem?

@JayWood
Copy link
Owner

JayWood commented Sep 6, 2015

aha! That may be it, will test!

@sergeyk93
Copy link
Author

Sorry, I've forgot to update!
I've already tested it and it works :)
Thanks for the update!

@JayWood
Copy link
Owner

JayWood commented Sep 6, 2015

So you changed the url to # instead of an actual url? If that's the case, this is still a bug, the cookie should set before the redirect occurs.

@sergeyk93
Copy link
Author

Yes I did.
It was the full URL including 'http://' and I've changed it all to just '#' and it fixed it.
Happy debugging!

@JayWood
Copy link
Owner

JayWood commented Sep 11, 2015

I'm still unable to replicate this, for now I'll close it, if you get the time feel free to post a full screenshot of the broken settings.

@JayWood JayWood closed this as completed Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants