Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettify "No version set" #24

Open
Rudloff opened this issue Jun 23, 2020 · 1 comment
Open

Prettify "No version set" #24

Rudloff opened this issue Jun 23, 2020 · 1 comment
Labels
enhancement

Comments

@Rudloff
Copy link

Rudloff commented Jun 23, 2020

When Composer can not determine the version of a package, it sets it to No version set (parsed as 1.0.0)@.
(For example, this happens for the root package if we are not in a Git repository.)

Maybe PrettyVersions could return something more user-friendly like null or "unknown"?
@Jean85
Copy link
Owner

Jean85 commented Jun 24, 2020

This seems an interesting suggestion!
If I will not have the time to do it myself, I'm happy to review a PR with this.

@limingxinleo limingxinleo mentioned this issue Jan 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed type hint error when the package's pretty_version is null. forkgroup/pretty-package-versions
2 participants
@Rudloff @Jean85