Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getShortCommit method #7

Closed
emodric opened this issue Jun 13, 2018 · 2 comments
Closed

getShortCommit method #7

emodric opened this issue Jun 13, 2018 · 2 comments
Labels
enhancement

Comments

@emodric
Copy link
Contributor

emodric commented Jun 13, 2018

Would it be possible to add a getShortCommit method, that will return the second part (after @) of the getVersionWithShortCommit output?

Thanks!
@Jean85
Copy link
Owner

Jean85 commented Jun 13, 2018

That should be pretty easy to implement, why not! Are you willing to submit a PR? It would need tests too BTW!

@emodric
Copy link
Contributor Author

emodric commented Jun 13, 2018

On it :)

@emodric emodric mentioned this issue Jun 13, 2018
Merged
@Jean85 Jean85 closed this as completed in #8 Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emodric @Jean85