-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled options are keyboard selectable #378
Comments
Are you on the latest version (0.6.2) this was fixed around 0.6.0, and there's an explicit test for this behaviour, so it shouldn't have come back! |
Ah sorry about that! Somehow missed #274 and was < 6.0. Works great, thanks! |
@bruderstein go to the example page http://jedwatson.github.io/react-select. For the first select called "STATES" choose "US". Type inside the select "Alabama" and hit enter. The disabled option is selected. Expected behavior: the disabled option should not be selectable via keyboard |
@cosminnicula this is the case for me at least, we fixed this in the last release (hence the issue is closed) Is "Alabama" still selectable via keyboard for you? If so, can you double check you've refreshed, and then let us know the browser & version? |
I've tested this directly on the examples website http://jedwatson.github.io/react-select |
Ah, I see now the issue, when we type and it's the only option available. Apologies, I hadn't properly followed your instructions. I've reopened the issue, and I'll aim to get a PR in tonight. Thank you for reporting. |
Observed:
Setting an option as disabled blocks mouse focus/selection, but when tabbing through the list with a keyboard, the option enters a focus state and can still be selected.
Expected:
Setting an option as disabled blocks mouse and keyboard focus/selection.
The text was updated successfully, but these errors were encountered: