Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled options are keyboard selectable #378

Closed
bhstahl opened this issue Aug 13, 2015 · 6 comments
Closed

Disabled options are keyboard selectable #378

bhstahl opened this issue Aug 13, 2015 · 6 comments

Comments

@bhstahl
Copy link

bhstahl commented Aug 13, 2015

Observed:

Setting an option as disabled blocks mouse focus/selection, but when tabbing through the list with a keyboard, the option enters a focus state and can still be selected.

Expected:

Setting an option as disabled blocks mouse and keyboard focus/selection.

@bruderstein
Copy link
Collaborator

Are you on the latest version (0.6.2) this was fixed around 0.6.0, and there's an explicit test for this behaviour, so it shouldn't have come back!

@bhstahl
Copy link
Author

bhstahl commented Aug 13, 2015

Ah sorry about that! Somehow missed #274 and was < 6.0. Works great, thanks!

@bhstahl bhstahl closed this as completed Aug 13, 2015
@cosminnicula
Copy link

@bruderstein go to the example page http://jedwatson.github.io/react-select. For the first select called "STATES" choose "US". Type inside the select "Alabama" and hit enter. The disabled option is selected.

Expected behavior: the disabled option should not be selectable via keyboard

@bruderstein
Copy link
Collaborator

@cosminnicula this is the case for me at least, we fixed this in the last release (hence the issue is closed)

Is "Alabama" still selectable via keyboard for you? If so, can you double check you've refreshed, and then let us know the browser & version?

@cosminnicula
Copy link

I've tested this directly on the examples website http://jedwatson.github.io/react-select

@bruderstein
Copy link
Collaborator

Ah, I see now the issue, when we type and it's the only option available. Apologies, I hadn't properly followed your instructions. I've reopened the issue, and I'll aim to get a PR in tonight.

Thank you for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants