Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on HitCountFooterModule #39

Closed
ric2016 opened this issue Sep 24, 2023 · 1 comment
Closed

Dependency on HitCountFooterModule #39

ric2016 opened this issue Sep 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ric2016
Copy link

ric2016 commented Sep 24, 2023

The functionality "copy/paste mechanism for source citations in the individual and family view" requires the 'Hit counters' footer module to be enabled (additionally, the tree preference "Hit counters" must be set to "show"), otherwise the copy icon isn't displayed.

This is caused by checking specific session parameters, here and a few lines later. These session parameters are only set in the 'Hit counters' footer module, here.

The easiest way to remove this dependency is probably to duplicate these Session parameters under different names and set them within the custom module.

@Jefferson49
Copy link
Owner

Thank you for this important hint to the dependency.

The background is that I was facing difficulties to get the context of a fact's gedcom to be shown with "fact-gedcom-fields.phtml". In fact-gedcom-fields.phtml, only the Gedcom and the parent tags are handed over and it is not known to which individual or family they belong. The mentioned session parameters are a nice workaround to get this context information, but I agree that there should not be a dependency.

At the moment, I do not know how to solve this. I will check the 'Hit counters' footer module and try to learn how it sets the session variables. Maybe, I can use a simular approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants