Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to current hostname #17

Open
georgehemmings opened this issue Oct 19, 2015 · 3 comments
Open

Fallback to current hostname #17

georgehemmings opened this issue Oct 19, 2015 · 3 comments

Comments

@georgehemmings
Copy link
Contributor

If the NotificationHostName is not set when building the notification URL, is there any reason it can't just fallback to context.HttpContext.Request.Url.Host ?

https://github.com/JeremySkinner/SagePayMvc/blob/master/src/SagePayMvc/DefaultUrlResolver.cs#L56

@JeremySkinner
Copy link
Owner

That's a good idea - feel free to submit a pull request if you like, otherwise I'll try and change it later this week,

@MrChriZ
Copy link

MrChriZ commented Aug 19, 2019

It would be great to see these changes pulled in Jeremy - they seem good.

@JeremySkinner
Copy link
Owner

@MrChriZ I’m not maintaining this project anymore I’m afraid...last commit was 4 years ago. If I get some time I’ll try and get outstanding PRs merged in, and do a final release before I archive the project but it’s not likely that I’ll get to it anytime soon I’m afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants