Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm mandatory? #87

Open
lensbart opened this issue Jan 4, 2025 · 5 comments
Open

pnpm mandatory? #87

lensbart opened this issue Jan 4, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@lensbart
Copy link

lensbart commented Jan 4, 2025

When running npm i -D storybook-addon-remix-react-router (as per the README) I get

npm warn ERESOLVE overriding peer dependency
npm error code 1
npm error path node_modules/storybook-addon-remix-react-router
npm error command failed
npm error command sh -c npx only-allow pnpm
npm error ╔═════════════════════════════════════════════════════════════╗
npm error ║                                                             ║
npm error ║   Use "pnpm install" for installation in this project.      ║
npm error ║                                                             ║
npm error ║   If you don't have pnpm, install it via "npm i -g pnpm".   ║
npm error ║   For more details, go to https://pnpm.js.org/              ║
npm error ║                                                             ║
npm error ╚═════════════════════════════════════════════════════════════╝
npm error (node:65713) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
npm error (Use `node --trace-deprecation ...` to show where the warning was created)
npm error npx: installed 2 in 1.07s
npm error A complete log of this run can be found in: ~/.npm/_logs/2025-01-04T00_27_28_768Z-debug-0.log

I suppose this is due to this line. I don’t understand the restriction to only allow PNPM? If this wasn’t included by accident, the Getting Started instructions should probably mention pnpm instead of npm.

Thanks!

@lensbart lensbart added the bug Something isn't working label Jan 4, 2025
@JesusTheHun
Copy link
Owner

@lensbart What version of node and npm do you use ? I just tested with node v18.16.1 and npm v9.5.1 and it works just fine

@lensbart
Copy link
Author

lensbart commented Jan 4, 2025

node v22.11.0
npm 10.9.0

{
	"devDependencies": {
		"@storybook/addon-essentials": "^8.4.7",
		"@storybook/addon-interactions": "^8.4.7",
		"@storybook/addon-links": "^8.4.7",
		"@storybook/addon-onboarding": "^8.4.7",
		"@storybook/blocks": "^8.4.7",
		"@storybook/react": "^8.4.7",
		"@storybook/react-vite": "^8.4.7",
		"@storybook/test": "^8.4.7",
		"storybook": "^8.4.7",
	}
}

@lensbart
Copy link
Author

lensbart commented Jan 4, 2025

In my case, it turns out I didn’t need this package. Eventually I found these instructions to fix the problem I had with RRv7. So feel free to close the issue

Happy new year

@JesusTheHun
Copy link
Owner

@lensbart just tried it, it works. Can you run npx envinfo --system --binaries please ?

@lensbart
Copy link
Author

lensbart commented Jan 4, 2025

(node:74845) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
npx: installed 1 in 0.676s

  System:
    OS: macOS 15.2
    CPU: (16) arm64 Apple M3 Max
    Memory: 3.11 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/.nvm/versions/node/v22.11.0/bin/node
    npm: 10.9.0 - ~/.nvm/versions/node/v22.11.0/bin/npm
    pnpm: 9.1.1 - ~/Library/pnpm/pnpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants