Fix focusable parameter for Window and Dialog #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
dima-avdeev-jb
approved these changes
May 30, 2022
eymar
pushed a commit
that referenced
this pull request
Jun 27, 2022
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
eymar
pushed a commit
that referenced
this pull request
Jun 28, 2022
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
igordmn
added a commit
that referenced
this pull request
Aug 18, 2022
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
igordmn
added a commit
that referenced
this pull request
Aug 18, 2022
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
eymar
pushed a commit
that referenced
this pull request
Oct 26, 2022
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
setFocusable make the root component focusable, not the window itself. For Window we should use setFocusableWindowState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setFocusable makes the root component focusable, not the window itself. For Window we should use setFocusableWindowState